docs link 404 error in CONTRIBUTING.md

[friedshoes]

Description

when I click the Conventions - “our style guide” and "building the documentation." link in the Contributing documentation for docker/cli, it takes me to a page that returns a 404 error.

Reproduce

.

Expected behavior

.

docker version

.

docker info

.

Additional Info

I’m still new to issue reporting. Please let me know if there’s anything I’ve missed.

[thaJeztah]

Thanks for reporting!

@dvdksn were these moved in the docs? What's the new location, and can we add a redirect (as there will be many branches / tags that have that link)

(For the second link, we probably should remove it, as it's specific to building the whole docs.docker.com, probably out of scope for this repository)

[friedshoes]

Got it. Can I open a PR to remove the second link ("and instructions on building the documentation.")?

thank you 😁

[dvdksn]

The canonical place to link to for contributions in docker/docs should be its CONTRIBUTING.md

[thaJeztah]

@dvdksn do we still have a page that we render on docs.docker.com for the style guide? https://docs.docker.com/contribute/style/grammar/

Perhaps we can make the old URLs (https://docs.docker.com/contribute/, https://docs.docker.com/contribute/style/grammar/) redirect to the GitHub repository (mostly want to make sure that old releases / branches would still have a link that works))

[dvdksn]

No we don't have those pages anymore- it's markdown files in the repository now. STYLE.md has the "voice and tone" stuff. I would rather not add more redirects, I think it's fine if the link is fixed on master and going forward..