fix: Fix null pointer exception#5136
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| elif type(v) == dict: | ||
| self.handle_variables(v) | ||
| if (type(v) == list) and (type(v[0]) == str): | ||
| elif (type(v) == list) and len(v) > 0 and (type(v[0]) == str): |
There was a problem hiding this comment.
避免 v[0] 空指针（以前合并的PR漏改的一处问题）
| workspace_user_role_mapping_list], []))) | ||
| cache.set(key, workspace_list, version=version) | ||
| return role_list | ||
| cache.set(key, role_list, version=version) |
There was a problem hiding this comment.
workspace_list 始终为 None，直接重命名变量，解决缓存为空的问题，同时使变量名更加合理。
| if len(title_row_list) == 1: | ||
| title_row_index_dict['content'] = 0 | ||
| elif len(title_row_list) == 1: | ||
| elif len(title_row_list) == 2: |
| class EmbedDocuments(serializers.Serializer): | ||
| texts = serializers.ListField(required=True, child=serializers.CharField(required=True, | ||
| label=_('vector text')), | ||
| label=_('vector text list')), |
There was a problem hiding this comment.
多了一个逗号，导致 texts 属性变成了 tuple 类型，真正的属性值被包装了一层。
| class EmbedDocuments(serializers.Serializer): | ||
| texts = serializers.ListField(required=True, child=serializers.CharField(required=True, | ||
| label=_('vector text')), | ||
| label=_('vector text list')), |
There was a problem hiding this comment.
同上：多了一个逗号，导致 texts 属性变成了 tuple 类型，真正的属性值被包装了一层。
| maxkb_logger.info("视频生成完成！视频 URL:", rsp.output.video_url) | ||
| if rsp.output.task_status == "SUCCEEDED": | ||
| maxkb_logger.info("视频生成完成！视频 URL:", rsp.output.video_url) | ||
| maxkb_logger.info(f'视频生成完成！视频 URL: {rsp.output.video_url}') |
There was a problem hiding this comment.
上面重复记录了日志，删除掉上面的，保存 if 里面的成功日志， else 里另外有记录失败的日志。
1 participant
What this PR does / why we need it?
fix: Fix null pointer exception
Summary of your change
修复一处空指针，和一个缓存为空的问题。
Please indicate you've done the following: