Skip to content

[AutoPR @azure-arm-compute]-generated-from-SDK Generation - JS-6183422#38228

Open
azure-sdk wants to merge 1 commit intomainfrom
sdkauto/@azure-arm-compute-6183422
Open

[AutoPR @azure-arm-compute]-generated-from-SDK Generation - JS-6183422#38228
azure-sdk wants to merge 1 commit intomainfrom
sdkauto/@azure-arm-compute-6183422

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Apr 21, 2026

Configurations: 'specification/compute/resource-manager/Microsoft.Compute/Compute/tspconfig.yaml', API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: '1e6111d12c709c3395fb8546e311b6c67fd87efc' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6183422 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://apps.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0a71fedf-e83c-f111-88b4-000d3a3b829d Submitted by: audreytoney@microsoft.com

Release Plan Details

…pute/Compute/tspconfig.yaml', API Version: 2025-11-01, SDK Release Type: stable, and CommitSHA: '1e6111d12c709c3395fb8546e311b6c67fd87efc' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6183422 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Apr 21, 2026
@kazrael2119 kazrael2119 marked this pull request as ready for review April 21, 2026 01:54
Copilot AI review requested due to automatic review settings April 21, 2026 01:54
@kazrael2119 kazrael2119 added Self-Service Release PR for self-service release first-typespec-migration first time to migrate to typespec mgmt-review-needed labels Apr 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Auto-generated refresh of @azure/arm-compute for the 2025-11-01 API version, updating samples and API surface artifacts for the stable release.

Changes:

  • Regenerated many samples-dev/* to align with the 2025-11-01 spec (updated method shapes, removed dotenv/config, simplified parameters).
  • Added new API Extractor reports in sdk/compute/arm-compute/review/.
  • Introduced an eslint.config.mjs and adjusted CODEOWNERS labeling for compute reviews.

Reviewed changes

Copilot reviewed 229 out of 1907 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sdk/compute/arm-compute/samples-dev/virtualMachineImagesListPublishersSample.ts Regenerated VM image publishers sample for 2025-11-01; simplified inputs.
sdk/compute/arm-compute/samples-dev/virtualMachineImagesListOffersSample.ts Regenerated VM image offers sample for 2025-11-01; simplified inputs.
sdk/compute/arm-compute/samples-dev/virtualMachineImagesGetSample.ts Regenerated VM image get sample for 2025-11-01; simplified inputs.
sdk/compute/arm-compute/samples-dev/virtualMachineImagesEdgeZoneListPublishersSample.ts Regenerated edge zone publishers sample for 2025-11-01; simplified inputs.
sdk/compute/arm-compute/samples-dev/virtualMachineExtensionsDeleteSample.ts Regenerated VM extension delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/virtualMachineExtensionImagesListTypesSample.ts Regenerated extension image types listing sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/virtualMachineExtensionImagesGetSample.ts Regenerated extension image get sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/usageListSample.ts Updated usage listing sample to new client shape (client.usage.list).
sdk/compute/arm-compute/samples-dev/sshPublicKeysListBySubscriptionSample.ts Regenerated SSH public keys list-by-subscription sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/sshPublicKeysGetSample.ts Regenerated SSH public key get sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/sshPublicKeysDeleteSample.ts Regenerated SSH public key delete sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/sshPublicKeysCreateSample.ts Regenerated SSH public key create sample; inline parameter object.
sdk/compute/arm-compute/samples-dev/softDeletedResourceListByArtifactNameSample.ts Regenerated soft-deleted resource listing sample; simplified args.
sdk/compute/arm-compute/samples-dev/snapshotsRevokeAccessSample.ts Regenerated snapshot revoke access sample; switched to updated revoke call pattern.
sdk/compute/arm-compute/samples-dev/snapshotsListSample.ts Regenerated snapshot list sample for 2025-11-01.
sdk/compute/arm-compute/samples-dev/snapshotsListByResourceGroupSample.ts Regenerated snapshot list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/snapshotsGrantAccessSample.ts Regenerated snapshot grant access sample; inline request body.
sdk/compute/arm-compute/samples-dev/snapshotsGetSample.ts Regenerated snapshot get samples; simplified args.
sdk/compute/arm-compute/samples-dev/snapshotsDeleteSample.ts Regenerated snapshot delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/sharedGalleryImagesListSample.ts Regenerated shared gallery images list sample; simplified args.
sdk/compute/arm-compute/samples-dev/sharedGalleryImagesGetSample.ts Regenerated shared gallery image get sample; simplified args.
sdk/compute/arm-compute/samples-dev/sharedGalleryImageVersionsListSample.ts Regenerated shared gallery image versions list sample; simplified args.
sdk/compute/arm-compute/samples-dev/sharedGalleryImageVersionsGetSample.ts Regenerated shared gallery image version get sample; simplified args.
sdk/compute/arm-compute/samples-dev/sharedGalleriesListSample.ts Regenerated shared galleries list sample; simplified args.
sdk/compute/arm-compute/samples-dev/sharedGalleriesGetSample.ts Regenerated shared gallery get sample; simplified args.
sdk/compute/arm-compute/samples-dev/restorePointsGetSample.ts Regenerated restore point get samples; simplified args.
sdk/compute/arm-compute/samples-dev/restorePointsDeleteSample.ts Regenerated restore point delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/restorePointCollectionsListSample.ts Regenerated restore point collections list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/restorePointCollectionsListAllSample.ts Regenerated restore point collections list-all sample; simplified args.
sdk/compute/arm-compute/samples-dev/restorePointCollectionsGetSample.ts Regenerated restore point collection get samples; simplified args.
sdk/compute/arm-compute/samples-dev/restorePointCollectionsDeleteSample.ts Regenerated restore point collection delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsUpdateSample.ts Regenerated PPG update sample; inline patch object.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsListBySubscriptionSample.ts Regenerated PPG list-by-subscription sample; simplified args.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsListByResourceGroupSample.ts Regenerated PPG list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsGetSample.ts Regenerated PPG get sample; simplified args.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsDeleteSample.ts Regenerated PPG delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/proximityPlacementGroupsCreateOrUpdateSample.ts Regenerated PPG create/update sample; inline request body.
sdk/compute/arm-compute/samples-dev/operationsListSample.ts Updated operations list sample; changed client construction signature.
sdk/compute/arm-compute/samples-dev/logAnalyticsExportThrottledRequestsSample.ts Regenerated log analytics throttled requests export sample; inline request body.
sdk/compute/arm-compute/samples-dev/logAnalyticsExportRequestRateByIntervalSample.ts Regenerated log analytics request-rate export sample; inline request body.
sdk/compute/arm-compute/samples-dev/imagesUpdateSample.ts Regenerated image update sample; switched to updated update call pattern.
sdk/compute/arm-compute/samples-dev/imagesListSample.ts Regenerated images list sample; simplified args.
sdk/compute/arm-compute/samples-dev/imagesListByResourceGroupSample.ts Regenerated images list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/imagesGetSample.ts Regenerated image get sample; simplified args.
sdk/compute/arm-compute/samples-dev/imagesDeleteSample.ts Regenerated image delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryScriptsUpdateSample.ts Regenerated gallery script update sample; switched to updated update call pattern.
sdk/compute/arm-compute/samples-dev/galleryScriptsListByGallerySample.ts Regenerated gallery scripts list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryScriptsGetSample.ts Regenerated gallery script get sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryScriptsDeleteSample.ts Regenerated gallery script delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryScriptsCreateOrUpdateSample.ts Regenerated gallery script create/update sample; switched to updated createOrUpdate call.
sdk/compute/arm-compute/samples-dev/galleryScriptVersionsListByGalleryScriptSample.ts Regenerated gallery script versions list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryScriptVersionsDeleteSample.ts Regenerated gallery script version delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfilesUpdateSample.ts Regenerated in-VM ACP update sample; switched to updated update call pattern.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfilesListByGallerySample.ts Regenerated in-VM ACP list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfilesGetSample.ts Regenerated in-VM ACP get sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfilesDeleteSample.ts Regenerated in-VM ACP delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfilesCreateOrUpdateSample.ts Regenerated in-VM ACP create/update sample; switched to updated createOrUpdate call.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfileVersionsUpdateSample.ts Regenerated in-VM ACP version update sample; switched to updated update call.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfileVersionsListByGalleryInVmaccessControlProfileSample.ts Removed older incorrectly-cased sample file.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfileVersionsListByGalleryInVMAccessControlProfileSample.ts Added regenerated sample with corrected casing and updated call pattern.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfileVersionsGetSample.ts Regenerated in-VM ACP version get sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryInVMAccessControlProfileVersionsDeleteSample.ts Regenerated in-VM ACP version delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryImagesListByGallerySample.ts Regenerated gallery images list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryImagesGetSample.ts Regenerated gallery image get sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryImagesDeleteSample.ts Regenerated gallery image delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryImagesCreateOrUpdateSample.ts Regenerated gallery image create/update sample; switched to updated createOrUpdate call.
sdk/compute/arm-compute/samples-dev/galleryImageVersionsListByGalleryImageSample.ts Regenerated gallery image versions list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryImageVersionsDeleteSample.ts Regenerated gallery image version delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryApplicationsUpdateSample.ts Regenerated gallery application update sample; switched to updated update call.
sdk/compute/arm-compute/samples-dev/galleryApplicationsListByGallerySample.ts Regenerated gallery applications list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryApplicationsGetSample.ts Regenerated gallery application get sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryApplicationsDeleteSample.ts Regenerated gallery application delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleryApplicationVersionsListByGalleryApplicationSample.ts Regenerated gallery app versions list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleryApplicationVersionsDeleteSample.ts Regenerated gallery app version delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/galleriesUpdateSample.ts Regenerated gallery update sample; switched to updated update call.
sdk/compute/arm-compute/samples-dev/galleriesListSample.ts Regenerated galleries list sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleriesListByResourceGroupSample.ts Regenerated galleries list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/galleriesDeleteSample.ts Regenerated gallery delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/disksRevokeAccessSample.ts Regenerated disk revoke access sample; switched to updated revoke call.
sdk/compute/arm-compute/samples-dev/disksListSample.ts Regenerated disks list sample; simplified args.
sdk/compute/arm-compute/samples-dev/disksListByResourceGroupSample.ts Regenerated disks list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/disksGetSample.ts Regenerated disk get sample; simplified args.
sdk/compute/arm-compute/samples-dev/disksDeleteSample.ts Regenerated disk delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/diskRestorePointRevokeAccessSample.ts Regenerated disk restore point revoke access sample; switched to updated revoke call.
sdk/compute/arm-compute/samples-dev/diskRestorePointListByRestorePointSample.ts Regenerated disk restore point list sample; updated client property name.
sdk/compute/arm-compute/samples-dev/diskRestorePointGrantAccessSample.ts Regenerated disk restore point grant access sample; inline request body.
sdk/compute/arm-compute/samples-dev/diskEncryptionSetsListSample.ts Regenerated disk encryption sets list sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskEncryptionSetsListByResourceGroupSample.ts Regenerated disk encryption sets list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskEncryptionSetsListAssociatedResourcesSample.ts Regenerated disk encryption set associated resources sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskEncryptionSetsDeleteSample.ts Regenerated disk encryption set delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/diskAccessesUpdateSample.ts Regenerated disk access update sample; switched to updated update call.
sdk/compute/arm-compute/samples-dev/diskAccessesUpdateAPrivateEndpointConnectionSample.ts Regenerated private endpoint connection approval sample; switched to updated update call.
sdk/compute/arm-compute/samples-dev/diskAccessesListSample.ts Regenerated disk access list sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskAccessesListPrivateEndpointConnectionsSample.ts Regenerated disk access private endpoint connections listing sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskAccessesListByResourceGroupSample.ts Regenerated disk access list-by-RG sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskAccessesGetSample.ts Regenerated disk access get samples; reordered function naming and spec links.
sdk/compute/arm-compute/samples-dev/diskAccessesGetPrivateLinkResourcesSample.ts Regenerated private link resources sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskAccessesGetAPrivateEndpointConnectionSample.ts Regenerated get private endpoint connection sample; simplified args.
sdk/compute/arm-compute/samples-dev/diskAccessesDeleteSample.ts Regenerated disk access delete sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/diskAccessesDeleteAPrivateEndpointConnectionSample.ts Regenerated delete private endpoint connection sample; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/diskAccessesCreateOrUpdateSample.ts Regenerated disk access create/update sample; switched to updated createOrUpdate call.
sdk/compute/arm-compute/samples-dev/dedicatedHostsRestartSample.ts Regenerated dedicated host restart sample; switched to updated restart call pattern.
sdk/compute/arm-compute/samples-dev/dedicatedHostsRedeploySample.ts Regenerated dedicated host redeploy sample; switched to updated redeploy call pattern.
sdk/compute/arm-compute/samples-dev/dedicatedHostsListAvailableSizesSample.ts Regenerated dedicated host sizes listing sample; simplified args.
sdk/compute/arm-compute/samples-dev/dedicatedHostsGetSample.ts Regenerated dedicated host get sample; inlined options bag.
sdk/compute/arm-compute/samples-dev/dedicatedHostsDeleteSample.ts Regenerated dedicated host delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/dedicatedHostsCreateOrUpdateSample.ts Regenerated dedicated host create/update sample; switched to updated createOrUpdate call.
sdk/compute/arm-compute/samples-dev/dedicatedHostGroupsDeleteSample.ts Regenerated dedicated host group delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/communityGalleryImagesListSample.ts Regenerated community gallery images list sample; simplified args.
sdk/compute/arm-compute/samples-dev/communityGalleryImagesGetSample.ts Regenerated community gallery image get sample; simplified args.
sdk/compute/arm-compute/samples-dev/communityGalleryImageVersionsListSample.ts Regenerated community gallery image versions list sample; simplified args.
sdk/compute/arm-compute/samples-dev/communityGalleryImageVersionsGetSample.ts Regenerated community gallery image version get sample; simplified args.
sdk/compute/arm-compute/samples-dev/communityGalleriesGetSample.ts Regenerated community gallery get sample; simplified args.
sdk/compute/arm-compute/samples-dev/cloudServicesUpdateSample.ts Removed cloud service sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesUpdateDomainWalkUpdateDomainSample.ts Removed cloud service update domain sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesUpdateDomainListUpdateDomainsSample.ts Removed cloud service update domain listing sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesUpdateDomainGetUpdateDomainSample.ts Removed cloud service update domain get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesStartSample.ts Removed cloud service start sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesRestartSample.ts Removed cloud service restart sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesReimageSample.ts Removed cloud service reimage sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesRebuildSample.ts Removed cloud service rebuild sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesPowerOffSample.ts Removed cloud service power off sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesListSample.ts Removed cloud service list sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesListAllSample.ts Removed cloud service list-all sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesGetSample.ts Removed cloud service get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesGetInstanceViewSample.ts Removed cloud service instance view sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesDeleteSample.ts Removed cloud service delete sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServicesDeleteInstancesSample.ts Removed cloud service delete instances sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRolesListSample.ts Removed cloud service roles listing sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRolesGetSample.ts Removed cloud service role get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesRestartSample.ts Removed cloud service role instance restart sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesReimageSample.ts Removed cloud service role instance reimage sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesRebuildSample.ts Removed cloud service role instance rebuild sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesListSample.ts Removed cloud service role instance list sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesGetSample.ts Removed cloud service role instance get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesGetRemoteDesktopFileSample.ts Removed cloud service role instance RDP file sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesGetInstanceViewSample.ts Removed cloud service role instance view sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceRoleInstancesDeleteSample.ts Removed cloud service role instance delete sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceOperatingSystemsListOSVersionsSample.ts Removed cloud service OS versions list sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceOperatingSystemsListOSFamiliesSample.ts Removed cloud service OS families list sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceOperatingSystemsGetOSVersionSample.ts Removed cloud service OS version get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/cloudServiceOperatingSystemsGetOSFamilySample.ts Removed cloud service OS family get sample tied to older CloudserviceRP API version.
sdk/compute/arm-compute/samples-dev/capacityReservationGroupsListByResourceGroupSample.ts Regenerated capacity reservation groups list sample; inlined options bag.
sdk/compute/arm-compute/samples-dev/availabilitySetsValidateMigrationToVirtualMachineScaleSetSample.ts Regenerated availability set validate migration sample; inline request body.
sdk/compute/arm-compute/samples-dev/availabilitySetsStartMigrationToVirtualMachineScaleSetSample.ts Regenerated availability set start migration sample; inline request body.
sdk/compute/arm-compute/samples-dev/availabilitySetsListSample.ts Regenerated availability sets list samples; simplified args.
sdk/compute/arm-compute/samples-dev/availabilitySetsListBySubscriptionSample.ts Regenerated availability sets list-by-subscription sample; inlined options bag.
sdk/compute/arm-compute/samples-dev/availabilitySetsGetSample.ts Regenerated availability sets get samples; simplified args.
sdk/compute/arm-compute/samples-dev/availabilitySetsDeleteSample.ts Regenerated availability sets delete samples; switched to updated delete call pattern.
sdk/compute/arm-compute/samples-dev/availabilitySetsConvertToVirtualMachineScaleSetSample.ts Regenerated convert-to-VMSS sample; switched from LRO helper to updated call pattern.
sdk/compute/arm-compute/samples-dev/availabilitySetsCancelMigrationToVirtualMachineScaleSetSample.ts Regenerated cancel migration sample; simplified args.
sdk/compute/arm-compute/review/arm-compute-models-computeSku-node.api.md Added API Extractor report for computeSku models (node entrypoint).
sdk/compute/arm-compute/review/arm-compute-api-node.api.md Added API Extractor report for node API surface (rest client factory).
sdk/compute/arm-compute/eslint.config.mjs Added ESLint flat config for package; custom rule severities/overrides.
sdk/compute/arm-compute/api-extractor.json Reformatted API extractor config (no functional change).
sdk/compute/arm-compute/_meta.json Removed legacy AutoRest metadata file.
.github/CODEOWNERS Updated compute CODEOWNERS label metadata to include mgmt review-needed.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread sdk/compute/arm-compute/samples-dev/operationsListSample.ts
Comment thread sdk/compute/arm-compute/samples-dev/operationsListSample.ts
Comment thread sdk/compute/arm-compute/eslint.config.mjs
@github-actions

This comment has been minimized.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No API design or tooling issues found in this PR. The @azure/arm-compute 24.0.0 TypeSpec migration looks clean:

  • Client name: ComputeManagementClient ✓ (correctly named)
  • Version alignment: package.json, computeManagementContext.ts (azsdk-js-arm-compute/24.0.0), and CHANGELOG.md all aligned to 24.0.0
  • CHANGELOG: compares 24.0.0 against previous stable 23.3.0 — no alpha version references ✓
  • API version: Compute 2025-11-01 is strictly newer than the Swagger-based predecessor ✓
  • Naming: No _N suffixes, no AutoGenerated suffixes, no _ prefixes on exported symbols ✓
  • Type safety: No unknown types in models (except valid enum members), no inappropriate void returns ✓
  • Exports: No ae-forgotten-export warnings in the API report ✓
  • KnownNetworkApiVersion: Stable network API versions (2020-11-01, 2022-11-01) preserved ✓
📊 Structured Report
{"agent":"mgmt-reviewer","pr":38228,"summary":"clean","findings":[]}

Benchmarked by Management Release Assistant

@github-actions
Copy link
Copy Markdown

Next Steps to Merge

Only failed checks and required actions are listed below.

  • UnitTest (ubuntu_22x_node, windows_20x_node, macoslatest_24x_node, windows_20x_browser): test/compute_examples.spec.ts imports @azure/arm-network which was removed from devDependencies during TypeSpec migration generation.
    Action: Either add @azure/arm-network back to devDependencies in package.json, or remove/skip test/compute_examples.spec.ts if it is no longer valid for the TypeSpec-generated SDK.
    Review ADO logs.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tool issue found in this PR (@azure/arm-compute 24.0.0, TypeSpec migration from 23.3.0):

  • Missing devDependency: @azure/arm-network was removed from devDependencies during code generation, but test/compute_examples.spec.ts still imports it — causing all UnitTest CI failures across all platforms.

No public API design issues were found: version progression (23.3.0 → 24.0.0) is valid, no _N-suffix types, no reserved-keyword operation names, userAgentInfo matches the package version, and the CHANGELOG contains no alpha-version comparisons.

📊 Structured Report
{"agent":"mgmt-reviewer","pr":38228,"summary":"issues_found","findings":[{"file":"sdk/compute/arm-compute/package.json","line":204,"issueType":"tool","category":"missing-devDependency","description":"`@azure/arm-network` was dropped from devDependencies during TypeSpec migration generation but is still imported by test/compute_examples.spec.ts, causing all UnitTest CI failures."}]}

Benchmarked by Management Release Assistant

"@azure/logger": "^1.2.0",
"tslib": "^2.8.1"
},
"devDependencies": {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Tool Issuepackage.json:204

The devDependencies section is missing @azure/arm-network, which was present in the previous version (^32.2.0) and is imported by test/compute_examples.spec.ts:

import type { VirtualNetwork, NetworkInterface, Subnet } from "`@azure/arm-network`";
import { NetworkManagementClient } from "`@azure/arm-network`";

It appears this dependency was dropped during TypeSpec migration code generation, causing all UnitTest CI failures across all platforms (ubuntu_22x_node, windows_20x_node, macoslatest_24x_node, windows_20x_browser).

Fix options:

  1. Add "@azure/arm-network": "^38.0.0" (or latest) to devDependencies, or
  2. Remove / skip test/compute_examples.spec.ts if it is no longer valid for the TypeSpec-generated SDK (it is annotated as AutoRest-generated and may be outdated).

Please report this generation gap to the autorest.typescript issue tracker.

@kazrael2119
Copy link
Copy Markdown
Member

Breaking Change Analysis: @azure/arm-compute 24.0.0

Old SDK (main) New SDK (PR)
Generator Swagger / AutoRest TypeSpec / emitter
API Version Prior stable (pre-2025-11-01) 2025-11-01
Package Version 23.3.0 24.0.0

Note: The main branch has no tsp-location.yaml, confirming the old SDK (23.3.0) was Swagger/AutoRest-generated. This PR is the first TypeSpec migration for @azure/arm-compute.

Total: 77 (Type 1) + 37 (Type 2) = 114 breaking changes


Type 1: API Version Upgrade (-> 2025-11-01) -- 77 items

# Breaking Change Count Detail
1 Cloud Services Classic removed from Compute TypeSpec scope 75 Azure Cloud Services (Classic) support is deprecated and was dropped from the Compute TypeSpec at API version 2025-11-01. All CloudService* interfaces, plus CS-related types (Extension, InstanceSku, OSFamily*, RoleInstance*, LoadBalancerConfiguration*, etc.) and their enums/type aliases are removed.
2 Removed operation VirtualMachineScaleSets.listOSUpgradeHistory 1 Operation renamed to getOSUpgradeHistory in the 2025-11-01 TypeSpec spec. The new operation is added in Features Added.
3 Removed Interface VirtualMachineScaleSetListOSUpgradeHistory 1 List wrapper for the renamed listOSUpgradeHistory operation. The new getOSUpgradeHistory returns PagedAsyncIterableIterator<UpgradeOperationHistoricalStatusInfo> directly (Pattern 2).

Type 2: TypeSpec / Emitter Migration -- 37 items

# Breaking Change Count Detail Accepted ✅ / ❌
1 Operation signature changes -- void return 10 LRO operations that previously returned header-only wrapper response types now return void. The old XxxResponse types were aliases for header interfaces with no meaningful body content. (Pattern 1 -- void return)
2 List/Collection interfaces removed 21 AutoRest-generated list wrapper types (XxxList) internalized by the TypeSpec emitter. Operations return PagedAsyncIterableIterator<T> directly. (Pattern 2)
3 Orphaned types removed 3 ResourceWithOptionalLocation (AutoRest base type not in TypeSpec), AvailabilitySetSkuTypes type alias, KnownAvailabilitySetSkuTypes enum -- not referenced by any operation in the new API surface. (Pattern 14)
4 Enum value renames (TypeSpec naming normalization) 3 KnownNetworkApiVersion: TwoThousandTwenty1101 -> NetworkApiVersion20201101, TwoThousandTwentyTwo1101 -> NetworkApiVersion20221101. KnownDiskSecurityTypes: ConfidentialVMVmguestStateOnlyEncryptedWithPlatformKey -> ConfidentialVMVMGuestStateOnlyEncryptedWithPlatformKey. Same underlying string values, only enum key names changed per TypeSpec naming convention.

Count check: 77 + 37 = 114 ✅


Detailed Breakdown

Type 1 Row 1: Cloud Services Classic Removed (75 items)

51 CloudService interfaces:*

  • Removed Interface CloudService
  • Removed Interface CloudServiceExtensionProfile
  • Removed Interface CloudServiceExtensionProperties
  • Removed Interface CloudServiceInstanceView
  • Removed Interface CloudServiceNetworkProfile
  • Removed Interface CloudServiceOperatingSystems
  • Removed Interface CloudServiceOperatingSystemsGetOSFamilyOptionalParams
  • Removed Interface CloudServiceOperatingSystemsGetOSVersionOptionalParams
  • Removed Interface CloudServiceOperatingSystemsListOSFamiliesOptionalParams
  • Removed Interface CloudServiceOperatingSystemsListOSVersionsOptionalParams
  • Removed Interface CloudServiceOsProfile
  • Removed Interface CloudServiceProperties
  • Removed Interface CloudServiceRole
  • Removed Interface CloudServiceRoleInstances
  • Removed Interface CloudServiceRoleInstancesDeleteOptionalParams
  • Removed Interface CloudServiceRoleInstancesGetInstanceViewOptionalParams
  • Removed Interface CloudServiceRoleInstancesGetOptionalParams
  • Removed Interface CloudServiceRoleInstancesGetRemoteDesktopFileOptionalParams
  • Removed Interface CloudServiceRoleInstancesListOptionalParams
  • Removed Interface CloudServiceRoleInstancesRebuildOptionalParams
  • Removed Interface CloudServiceRoleInstancesReimageOptionalParams
  • Removed Interface CloudServiceRoleInstancesRestartOptionalParams
  • Removed Interface CloudServiceRoleProfile
  • Removed Interface CloudServiceRoleProfileProperties
  • Removed Interface CloudServiceRoleProperties
  • Removed Interface CloudServiceRoles
  • Removed Interface CloudServiceRolesGetOptionalParams
  • Removed Interface CloudServiceRoleSku
  • Removed Interface CloudServiceRolesListOptionalParams
  • Removed Interface CloudServices
  • Removed Interface CloudServicesCreateOrUpdateOptionalParams
  • Removed Interface CloudServicesDeleteInstancesOptionalParams
  • Removed Interface CloudServicesDeleteOptionalParams
  • Removed Interface CloudServicesGetInstanceViewOptionalParams
  • Removed Interface CloudServicesGetOptionalParams
  • Removed Interface CloudServicesListAllOptionalParams
  • Removed Interface CloudServicesListOptionalParams
  • Removed Interface CloudServicesPowerOffOptionalParams
  • Removed Interface CloudServicesRebuildOptionalParams
  • Removed Interface CloudServicesReimageOptionalParams
  • Removed Interface CloudServicesRestartOptionalParams
  • Removed Interface CloudServicesStartOptionalParams
  • Removed Interface CloudServicesUpdateDomain
  • Removed Interface CloudServicesUpdateDomainGetUpdateDomainOptionalParams
  • Removed Interface CloudServicesUpdateDomainListUpdateDomainsOptionalParams
  • Removed Interface CloudServicesUpdateDomainWalkUpdateDomainOptionalParams
  • Removed Interface CloudServicesUpdateOptionalParams
  • Removed Interface CloudServiceUpdate
  • Removed Interface CloudServiceVaultAndSecretReference
  • Removed Interface CloudServiceVaultCertificate
  • Removed Interface CloudServiceVaultSecretGroup

20 other CS-related interfaces:

  • Removed Interface Extension (CS extension type)
  • Removed Interface InstanceSku (CS role instance SKU)
  • Removed Interface InstanceViewStatusesSummary (CS instance view)
  • Removed Interface LoadBalancerConfiguration (CS load balancer)
  • Removed Interface LoadBalancerConfigurationProperties
  • Removed Interface LoadBalancerFrontendIpConfiguration
  • Removed Interface LoadBalancerFrontendIpConfigurationProperties
  • Removed Interface OSFamily (CS OS family type)
  • Removed Interface OSFamilyProperties
  • Removed Interface OSVersion (CS OS version type)
  • Removed Interface OSVersionProperties
  • Removed Interface OSVersionPropertiesBase
  • Removed Interface ResourceInstanceViewStatus (CS instance view status)
  • Removed Interface RoleInstance (CS role instance)
  • Removed Interface RoleInstanceNetworkProfile
  • Removed Interface RoleInstanceProperties
  • Removed Interface RoleInstances
  • Removed Interface RoleInstanceView
  • Removed Interface StatusCodeCount (CS status count)
  • Removed Interface UpdateDomain (CS update domain)

2 type aliases + 2 enums:

  • Removed Type Alias CloudServiceSlotType
  • Removed Type Alias CloudServiceUpgradeMode
  • Removed Enum KnownCloudServiceSlotType
  • Removed Enum KnownCloudServiceUpgradeMode
Type 2 Row 1: Operation Signature Changes -- Void Return (10 items, Pattern 1)

All 10 operations previously returned header-only wrapper response types (e.g. XxxResponse = XxxHeaders). The TypeSpec emitter infers these as void-returning operations since the headers have no meaningful body payload.

Operation Old Return Type New Return Type
AvailabilitySets.beginConvertToVirtualMachineScaleSetAndWait Promise<AvailabilitySetsConvertToVirtualMachineScaleSetResponse> Promise<void>
DedicatedHosts.beginRedeployAndWait Promise<DedicatedHostsRedeployResponse> Promise<void>
DedicatedHosts.beginRestartAndWait Promise<DedicatedHostsRestartResponse> Promise<void>
GalleryInVMAccessControlProfiles.beginDeleteAndWait Promise<GalleryInVMAccessControlProfilesDeleteResponse> Promise<void>
GalleryInVMAccessControlProfileVersions.beginDeleteAndWait Promise<GalleryInVMAccessControlProfileVersionsDeleteResponse> Promise<void>
GalleryScripts.beginDeleteAndWait Promise<GalleryScriptsDeleteResponse> Promise<void>
GalleryScriptVersions.beginDeleteAndWait Promise<GalleryScriptVersionsDeleteResponse> Promise<void>
VirtualMachines.beginMigrateToVMScaleSetAndWait Promise<VirtualMachinesMigrateToVMScaleSetResponse> Promise<void>
VirtualMachineScaleSets.beginApproveRollingUpgradeAndWait Promise<VirtualMachineScaleSetsApproveRollingUpgradeResponse> Promise<void>
VirtualMachineScaleSetVMs.beginApproveRollingUpgradeAndWait Promise<VirtualMachineScaleSetVMsApproveRollingUpgradeResponse> Promise<void>
Type 2 Row 2: List/Collection Interfaces Removed (21 items, Pattern 2)

AutoRest-generated list wrapper interfaces are internalized by the TypeSpec emitter. Operations now return PagedAsyncIterableIterator<T> directly.

  • Removed Interface CommunityGalleryImageList
  • Removed Interface CommunityGalleryImageVersionList
  • Removed Interface DiskAccessList
  • Removed Interface DiskEncryptionSetList
  • Removed Interface DiskList
  • Removed Interface DiskRestorePointList
  • Removed Interface GalleryApplicationList
  • Removed Interface GalleryApplicationVersionList
  • Removed Interface GalleryImageList
  • Removed Interface GalleryImageVersionList
  • Removed Interface GalleryInVMAccessControlProfileList
  • Removed Interface GalleryInVMAccessControlProfileVersionList
  • Removed Interface GalleryList
  • Removed Interface GalleryScriptList
  • Removed Interface GalleryScriptVersionList
  • Removed Interface GallerySoftDeletedResourceList
  • Removed Interface ResourceUriList
  • Removed Interface SharedGalleryImageList
  • Removed Interface SharedGalleryImageVersionList
  • Removed Interface SharedGalleryList
  • Removed Interface SnapshotList
Type 2 Row 3: Orphaned Types Removed (3 items, Pattern 14)

Not referenced by any operation or reachable model in the new API surface.

  • Removed Interface ResourceWithOptionalLocation -- AutoRest base type not present in TypeSpec; VirtualMachineExtension no longer extends it.
  • Removed Type Alias AvailabilitySetSkuTypes -- Enum type not used in any new operation or model.
  • Removed Enum KnownAvailabilitySetSkuTypes -- Accompanies the removed type alias.
Type 2 Row 4: Enum Value Renames (3 items, TypeSpec naming normalization)

The TypeSpec emitter uses a different naming convention for enum values than AutoRest. The underlying string values are unchanged.

  • KnownDiskSecurityTypes: ConfidentialVMVmguestStateOnlyEncryptedWithPlatformKey -> ConfidentialVMVMGuestStateOnlyEncryptedWithPlatformKey (casing: VMGuest normalized)
  • KnownNetworkApiVersion: TwoThousandTwenty1101 -> NetworkApiVersion20201101 (value stays "2020-11-01")
  • KnownNetworkApiVersion: TwoThousandTwentyTwo1101 -> NetworkApiVersion20221101 (value stays "2022-11-01")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-typespec-migration first time to migrate to typespec Mgmt This issue is related to a management-plane library. Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants