App Config Provider - Feature Flag Page based Etags#46412
Open
mrm9084 wants to merge 3 commits intoAzure:mainfrom
Open
App Config Provider - Feature Flag Page based Etags#46412mrm9084 wants to merge 3 commits intoAzure:mainfrom
mrm9084 wants to merge 3 commits intoAzure:mainfrom
Conversation
mrm9084
requested review from
avanigupta,
jimmyca15,
rossgrambo and
xiangyan99
as code owners
github-actions
bot
added
the
App Configuration
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Azure App Configuration Provider feature flag refresh to use page-based etag tracking (aligned with the earlier collection monitoring work in #45411), reducing the number of requests required to detect feature flag changes.
Changes:
- Switched feature flag refresh change-detection from per-flag etag checks to page-based etag checks (sync + async).
- Updated refresh samples to use AAD (endpoint + credential) instead of connection strings.
- Added changelog entry and removed an unused test import.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager.py | Returns feature flags with page etags; adds page-etag change check for feature flags (sync). |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_async_client_manager.py | Async equivalent: returns feature flags with page etags; adds page-etag change check for feature flags. |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py | Uses feature-flag page etag checking during refresh and stores feature-flag page etags. |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py | Async equivalent: uses/stores feature-flag page etags during refresh. |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationproviderbase.py | Replaces per-flag watched etags state with feature-flag page etags state. |
| sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample.py | Switches refresh sample from connection string auth to AAD auth. |
| sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample_feature_flags.py | Switches feature-flag refresh sample from connection string auth to AAD auth. |
| sdk/appconfiguration/azure-appconfiguration-provider/tests/test_azureappconfigurationproviderbase.py | Removes unused import. |
| sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md | Documents the switch to page-based etag checking for feature flag refresh. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates Feature Flags to use page based etags matching this pr #45411 for configuration settings.