Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azure-batch package for the 15.1.0 GA release by pointing generation at a newer azure-rest-api-specs commit and aligning the SDK surface with regenerated names/signatures.
Changes:
- Updated
tsp-location.yamlto a newerazure-rest-api-specscommit. - Renamed the Batch client “list subtasks” method shape (
list_sub_tasks→list_subtasks) across sync/async code and tests. - Refactored XML serialization/deserialization helpers in
model_base.py, and updated docs/changelog for 15.1.0 GA.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/batch/azure-batch/tsp-location.yaml | Bumps the API spec commit used for TypeSpec generation. |
| sdk/batch/azure-batch/tests/test_batch.py | Updates tests to call list_subtasks. |
| sdk/batch/azure-batch/azure/batch/aio/_patch.py | Adjusts aio client patch typing/docstrings for async credentials. |
| sdk/batch/azure-batch/azure/batch/aio/_operations/_patch.py | Changes default max_concurrency to Optional[int] = None for aio bulk task creation helper. |
| sdk/batch/azure-batch/azure/batch/aio/_operations/_operations.py | Renames subtasks request builder/method usage to subtasks. |
| sdk/batch/azure-batch/azure/batch/_utils/model_base.py | Refactors XML (de)serialization namespace handling and element naming. |
| sdk/batch/azure-batch/azure/batch/_operations/_patch.py | Changes default max_concurrency to Optional[int] = None for sync bulk task creation helper. |
| sdk/batch/azure-batch/azure/batch/_operations/_operations.py | Renames subtasks request builder and public method to list_subtasks. |
| sdk/batch/azure-batch/apiview-properties.json | Updates APIView mapping for renamed list_subtasks methods. |
| sdk/batch/azure-batch/README.md | Updates enum reference in examples (currently to models._enums). |
| sdk/batch/azure-batch/CHANGELOG.md | Expands 15.1.0 GA notes with breaking-changes details. |
a6a3e39 to
0add081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines