Fix WinGet activation order and repair false positives#4605
Draft
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit intomainfrom
Draft
Fix WinGet activation order and repair false positives#4605Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit intomainfrom
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4602.
This restores the intended WinGet native activation order and closes the false-positive path that kept prompting users to repair WinGet even when UniGetUI could continue working.
Root cause
A recent WinGet change made bundled in-proc COM the default native activation path. Older behavior preferred the system WinGet COM registration first and only fell back when needed.
That change left bundled activation in an awkward state:
NO_PACKAGES_HAVE_BEEN_LOADEDWhat changed
Files changed
src/UniGetUI.PackageEngine.Managers.WinGet/ClientHelpers/NativeWinGetHelper.cssrc/UniGetUI.PackageEngine.Tests/WinGetManagerTests.cssrc/UniGetUI/Pages/SettingsPages/ManagersPages/PackageManager.xaml.cssrc/UniGetUI/Pages/SoftwarePages/InstalledPackagesPage.csValidation
dotnet test .\\src\\UniGetUI.PackageEngine.Tests\\UniGetUI.PackageEngine.Tests.csproj --verbosity q --nologo --tl:offdotnet build .\\src\\UniGetUI\\UniGetUI.csproj -p:Platform=x64 --verbosity q --nologo --tl:offThe WinUI build still reports existing analyzer warnings outside this change set, but completed successfully.