Skip to content

fix the result size in ParallelResult#339

Open
zhongkechen wants to merge 2 commits intomainfrom
parallelResult
Open

fix the result size in ParallelResult#339
zhongkechen wants to merge 2 commits intomainfrom
parallelResult

Conversation

@zhongkechen
Copy link
Copy Markdown
Contributor

@zhongkechen zhongkechen commented Apr 20, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

Description

New branches could be added after the parallel operation has completed early due to minimal successful condition.

Fix:

  • reconstruct the result with the latest branch count when users call get() to retrieve the result.

Demo/Screenshots

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes?

Integration Tests

Have integration tests been written for these changes? Updated the test to catch the issue

Examples

Has a new example been added for the change? (if applicable)

@zhongkechen zhongkechen marked this pull request as ready for review April 20, 2026 21:49
@zhongkechen zhongkechen requested a review from a team April 20, 2026 21:49
@zhongkechen zhongkechen self-assigned this Apr 20, 2026
@zhongkechen zhongkechen enabled auto-merge (squash) April 20, 2026 23:15
@zhongkechen zhongkechen disabled auto-merge April 20, 2026 23:15
@zhongkechen zhongkechen added the bug Something isn't working label Apr 20, 2026
@zhongkechen zhongkechen force-pushed the parallelResult branch 2 times, most recently from 523a7a8 to fccb07c Compare April 20, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: some parallel branches may not be included in the ParallelResult when MIN_SUCCESSFUL_REACHED is returned

1 participant