Draft
Conversation
The R2R entrypoint lookup fix in readytoruninfo.cpp resolves dotnet#126755, so the CrossGenTest=false workaround added in dotnet#126775 can be removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CI failure in the covariant async return tests under ReadyToRun (R2R) by ensuring VM-synthesized “return-dropping” async thunks do not incorrectly bind to an unrelated R2R entry point, forcing the runtime to generate/compile the correct thunk at runtime.
Changes:
- Re-enable CrossGen/R2R testing for the
covariant-returnasync test project by removing theCrossGenTest=falseoverride. - Update
ReadyToRunInfo::GetEntryPointto bypass R2R entrypoint lookup forMethodDescinstances representing return-dropping async thunks, falling back to prestub/thunk generation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tests/async/covariant-return/covariant-returns.csproj |
Removes the CrossGenTest opt-out so the scenario is exercised again in CI. |
src/coreclr/vm/readytoruninfo.cpp |
Skips R2R entrypoint resolution for return-dropping thunks to avoid incorrect binding and ensure correct thunk codegen/dispatch. |
VSadov
approved these changes
Apr 21, 2026
Member
VSadov
left a comment
VSadov
left a comment
There was a problem hiding this comment.
LGTM. Scenarios that involve these thunks are very rare. It is ok to not r2r them.
This was referenced Apr 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should force the runtime to compile a new thunk and get the covariant tests passing in CI.