Add RDAP latency metrics

[jicelhay]

Add RDAP latency metrics to compare against RDAP SLA, as described in go/domain-registry-deployment

b/503799160

---

This change is 

[gbrodman]

need to change the commit message to have a verb

@gbrodman reviewed 4 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on jicelhay).

---

core/src/main/java/google/registry/rdap/RdapActionBase.java line 187 at r1 (raw file):

    RdapMetrics.RdapMetricInformation metricInfo = metricInformationBuilder.build();
    rdapMetrics.updateMetrics(metricInfo);
    rdapMetrics.recordProcessingTime(metricInfo, processingTime);

i think we should just include the processing time in the normal rdapMetrics object and record it inside the updateMetrics method, just like we do for other optional params (e.g. number of domains retrieved)

that way it'll get automatically picked up if we call setProcessingTime on the builder

---

core/src/test/java/google/registry/rdap/RdapActionBaseTest.java line 69 at r1 (raw file):

      }
      if (pathSearchString.equals("advanceClock")) {
        ((FakeClock) clock).advanceBy(millis(50));

i don't think the cast is necessary.

[jicelhay]

Done

@jicelhay made 3 comments.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on gbrodman).

---

core/src/main/java/google/registry/rdap/RdapActionBase.java line 187 at r1 (raw file):

Previously, gbrodman wrote…

i think we should just include the processing time in the normal rdapMetrics object and record it inside the updateMetrics method, just like we do for other optional params (e.g. number of domains retrieved)

that way it'll get automatically picked up if we call setProcessingTime on the builder

Done.

---

core/src/test/java/google/registry/rdap/RdapActionBaseTest.java line 69 at r1 (raw file):

Previously, gbrodman wrote…

i don't think the cast is necessary.

hm, the inherited clock object is declared as a Clock. I get compilation errors if I don't cast it which makes sense to me.

[gbrodman]

@gbrodman reviewed 4 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on jicelhay).

---

core/src/test/java/google/registry/rdap/RdapActionBaseTest.java line 69 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

hm, the inherited clock object is declared as a Clock. I get compilation errors if I don't cast it which makes sense to me.

oh whoops, i didn't see that this is within the RdapTestAction itself and not the RdapActionBaseTest test class