Add qubit loss support in QuantumErrorProfile and noise config support in qdk sparse state simulator#434
Open
Add qubit loss support in QuantumErrorProfile and noise config support in qdk sparse state simulator#434
Conversation
📊 Coverage Summary
Detailed Coverage ReportsC++ Coverage DetailsPython Coverage DetailsPybind11 Coverage Details |
RushiGong
requested review from
ConradJohnston,
nabbelbabbel and
wavefunction91
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates QDK/Chemistry’s noise modeling to support qubit loss via QuantumErrorProfile, and wires noise configuration support into the QDK sparse state simulator execution path.
Changes:
- Redesign
QuantumErrorProfile.errorsto support multiple error types per gate (includingqubit_loss) and update JSON/YAML/HDF5 serialization accordingly. - Add QDK sparse state simulator support for passing noise configs (and seed) into execution.
- Update Qiskit interop and the Python test suite/docs examples to use the new noise schema and validate qubit-loss behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/src/qdk_chemistry/data/noise_models.py | Adds qubit_loss, changes error schema to multi-error-per-gate, updates serialization and QDK noise config conversion. |
| python/src/qdk_chemistry/algorithms/circuit_executor/qdk.py | Passes noise config into sparse-state execution; updates measurement result → bitstring mapping to account for loss. |
| python/src/qdk_chemistry/plugins/qiskit/_interop/noise_model.py | Iterates multiple error types per gate; warns and skips unsupported types when building Aer noise models. |
| python/tests/conftest.py | Adds a fixture including qubit loss and updates the basic noise fixture schema. |
| python/tests/test_noise_models.py | Updates tests for new schema; adds coverage for multi-error-per-gate and qubit-loss behaviors. |
| python/tests/test_interop_qiskit_noise_model.py | Updates interop tests and adds warning/skip coverage for qubit_loss in Qiskit noise models. |
| python/tests/test_circuit_executor_qdk.py | Updates executor noise tests and enables noise for sparse-state simulator. |
| python/tests/test_phase_estimation_iterative.py | Updates QPE integration test noise profile schema. |
| python/tests/test_energy_estimator.py | Extends estimator tests to include the QDK sparse state simulator backend. |
| docs/source/_static/examples/python/circuit_executor.py | Updates documentation example to the new noise profile schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wavefunction91
requested changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.