fix(client): honor custom claims override in createPrivateKeyJwtAuth#1918
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
…reatePrivateKeyJwtAuth Remove redundant jose setter calls (.setIssuer, .setSubject, .setAudience, .setIssuedAt, .setExpirationTime, .setJti) that silently overwrote values from options.claims after they had been merged into the claims object. The six reserved claims are already present in the merged object via baseClaims, so the setter calls were redundant for the default case and harmful when users provided overrides -- contradicting the documented "custom claims taking precedence" contract. Fixes modelcontextprotocol#1914
🦋 Changeset detectedLatest commit: d27bb98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
josesetter calls (.setIssuer,.setSubject,.setAudience,.setIssuedAt,.setExpirationTime,.setJti) that silently overwrote user-provided custom claims after they had already been merged into theclaimsobject via{ ...baseClaims, ...options.claims }baseClaims, so the setter calls were redundant for the default case and harmful when users provided overrides -- contradicting the documented "custom claims taking precedence" contractiss,sub,aud) fromoptions.claimsare honored in the signed JWTFixes #1914