Open
Conversation
b5d6c2c to
011d5a6
Compare
fb8644c to
c5deef7
Compare
Vinnl
approved these changes
Apr 20, 2026
Vinnl
left a comment
There was a problem hiding this comment.
I can't comment on the Rust code and AS conventions, but I integrated this into Firefox using your patch, and it did what it says on the tin :)
Added some inline suggestions, but none of them are blockers, and for each of them one could also make a valid argument that they should be ignored, so 🤷
extracted from webext-storage
bendk
approved these changes
Apr 20, 2026
Contributor
bendk
left a comment
There was a problem hiding this comment.
The code looks good to me.
My only slight concern is that we should make sure we're tracking any errors that come from this component and fixing them. At some point soon I'd love to set up a dashboard so that credential management can do that. I've been working on the dashboards for a while and I think they're close to being ready for wider use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.