src: simplify and fix FFI ArrayBuffer accesses#62857
Open
addaleax wants to merge 2 commits intonodejs:mainfrom
Open
src: simplify and fix FFI ArrayBuffer accesses#62857addaleax wants to merge 2 commits intonodejs:mainfrom
addaleax wants to merge 2 commits intonodejs:mainfrom
Conversation
`ArrayBufferViewContents` supports `ArrayBuffer`s, so we do not need to provide special treatment for those. Also, small typed arrays may not have backing stores until their corresponding `ArrayBuffer`s are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62857 +/- ##
==========================================
- Coverage 89.64% 89.62% -0.03%
==========================================
Files 706 706
Lines 219137 219124 -13
Branches 41999 41981 -18
==========================================
- Hits 196453 196386 -67
- Misses 14574 14619 +45
- Partials 8110 8119 +9
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayBufferViewContentssupportsArrayBuffers, so we do not need to provide special treatment for those.Also, small typed arrays may not have backing stores until their corresponding
ArrayBuffers are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory.