src: align FFI error handling with Node.js source#62858
Open
addaleax wants to merge 2 commits intonodejs:mainfrom
Open
src: align FFI error handling with Node.js source#62858addaleax wants to merge 2 commits intonodejs:mainfrom
addaleax wants to merge 2 commits intonodejs:mainfrom
Conversation
Align the FFI error handling logic with the rest of the Node.js source. Refs: https://github.com/nodejs/node/blob/main/src/README.md#exception-handling Signed-off-by: Anna Henningsen <anna@addaleax.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62858 +/- ##
==========================================
- Coverage 89.64% 89.64% -0.01%
==========================================
Files 706 706
Lines 219137 219112 -25
Branches 41999 41978 -21
==========================================
- Hits 196453 196422 -31
- Misses 14574 14602 +28
+ Partials 8110 8088 -22
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the FFI error handling logic with the rest of the Node.js source.
Refs: https://github.com/nodejs/node/blob/main/src/README.md#exception-handling