quic: disable building ngtcp2 examples#62859
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
The ngtcp2 client and server examples are built with the intention of using them as reference implementations for future quic tests. However, as of ngtcp2 1.22.0, these examples require c++-23 libraries, which doesn't match the current Node.js build requirements. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Renegade334
added
quic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62859 +/- ##
==========================================
+ Coverage 89.61% 89.62% +0.01%
==========================================
Files 706 706
Lines 219136 219137 +1
Branches 41981 41980 -1
==========================================
+ Hits 196376 196403 +27
+ Misses 14671 14614 -57
- Partials 8089 8120 +31 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ngtcp2 client and server examples are built with the intention of using them as reference implementations for future quic tests. However, as of ngtcp2 1.22.0, these examples are using c++-23 libraries, which doesn't match the current Node.js build requirements.
These reference implementations aren't used in any actual quic tests yet, so the path of least resistance is to disable these for now.
Refs: #59946
Refs: #62595 (comment)