gh-113093: Add mode parameter to shelve.open#148807
Open
algonix01w-ai wants to merge 3 commits intopython:mainfrom
Open
gh-113093: Add mode parameter to shelve.open#148807algonix01w-ai wants to merge 3 commits intopython:mainfrom
algonix01w-ai wants to merge 3 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
|
There looks to be another recent PR on this #148662 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing
modeparameter toshelve.open()and theDbfilenameShelfclass.Currently,
shelve.opendoes not allow users to specify file permissions, even though the underlyingdbm.opensupports amodeparameter. This change ensures consistency between theshelveanddbmmodules, allowing users to set custom file permissions (e.g., restricted access) when creating a shelf database.Changes
DbfilenameShelf.__init__to acceptmodeas a keyword-only argument.shelve.opento acceptmodeand pass it toDbfilenameShelf.test_modeusingtempfile.TemporaryDirectoryto verify that themodeparameter is accepted and correctly passed through without errors.open()and added aversionchangednotice for 3.15.Linked Issue
Fixes gh-113093
Tests
Ran
python.bat -m test test_shelveon Windows 11. All tests passed successfully.📚 Documentation preview 📚: https://cpython-previews--148807.org.readthedocs.build/